Remove the ScarletModelData to LsstScarletModelData converter (DM-55150)#1386
Open
fred3m wants to merge 1 commit into
Open
Remove the ScarletModelData to LsstScarletModelData converter (DM-55150)#1386fred3m wants to merge 1 commit into
fred3m wants to merge 1 commit into
Conversation
A base ScarletModelData cannot be promoted to an LsstScarletModelData: the latter requires a single catalog-wide observed PSF and band list, while a ScarletModelData carries them per blend. The conversion never produced a usable model in the science pipelines, so drop the storage-class `converters` entry (and the now-removed `scarlet_model_to_lsst_scarlet_model` it referenced, deleted in a companion commit on this ticket). Old ScarletModelData datasets continue to load at their own storage class. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 89.62% 89.61% -0.01%
==========================================
Files 373 373
Lines 50780 50780
Branches 5913 5913
==========================================
- Hits 45510 45509 -1
Misses 3880 3880
- Partials 1390 1391 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A base ScarletModelData cannot be promoted to an LsstScarletModelData: the latter requires a single catalog-wide observed PSF and band list, while a ScarletModelData carries them per blend. The conversion never produced a usable model in the science pipelines, so drop the storage-class
convertersentry (and the now-removedscarlet_model_to_lsst_scarlet_modelit referenced, deleted in a companion commit on this ticket).Old ScarletModelData datasets continue to load at their own storage class.
Checklist
doc/changesconfigs/old_dimensionsand update the list indoc/lsst.daf.butler/dimensions.rst