Fix mig_inv_propagation crash when PO is a complement of constant or PI#694
Merged
Conversation
This commit fixes an issue that PO is a complement of constant or PI. Actually in `propagate_helper` it is properly handled, so simply followed the same condition
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 83.83% 84.22% +0.39%
==========================================
Files 189 189
Lines 29888 29074 -814
==========================================
- Hits 25056 24487 -569
+ Misses 4832 4587 -245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you! |
Contributor
Author
|
Thank you for the review! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue that PO is a complement of constant or PI. Actually in
propagate_helperhandled the propagation properly, so simply inserted the same conditionntk.is_constant(...) || ntk.is_pi(...).Fix #693.