Skip to content

Allow recursive types, BooleanLiteralTypeAnnotations and do not crash on function types#3

Open
vitalif wants to merge 6 commits into
loyd:masterfrom
vitalif:master
Open

Allow recursive types, BooleanLiteralTypeAnnotations and do not crash on function types#3
vitalif wants to merge 6 commits into
loyd:masterfrom
vitalif:master

Conversation

@vitalif

@vitalif vitalif commented May 23, 2019

Copy link
Copy Markdown

Hi!
Awesome module, thanks!
The only problems I've encountered are:

  • lack of BooleanLiteralTypeAnnotation support
  • lack of support for recursive types
  • crash (assert with null) on function types

I attempted to fix these problems, please see the PR.
It probably doesn't fix the recursive type problem for parametrized types, but at least it does so for simple ones.

@vitalif

vitalif commented May 23, 2019

Copy link
Copy Markdown
Author

It seems I've broken a lot :(
Can you give me a hint about how to fix the recursive type issue better?

@vitalif

vitalif commented May 23, 2019

Copy link
Copy Markdown
Author

Ok I've pushed new version, it still fails a lot of tests but changes are intended this time :)

@lyleunderwood

Copy link
Copy Markdown

@vitalif I just used your support for recursive types, super helpful, would love to see this merged.

@loyd This project has been working surprisingly well for my use case, but understandably it hasn't seen much maintenance for a while. Would you be interested in any help maintaining it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants