feat: Add support for WLL custom sign up fields - #481
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds White Label Login (WLL) support for retrieving configured custom sign-up fields and submitting answers to those fields when signing up, exposing the functionality through the public LootLockerSDKManager facade and covering key serialization behavior with tests.
Changes:
- Added a new WLL endpoint (
white-label-login/sign-up/fields) and request method to fetch sign-up field definitions. - Extended the WLL sign-up request model and added a new
LootLockerSDKManager.WhiteLabelSignUpoverload to sendcustom_fields. - Added PlayMode coverage for the new endpoint plus serialization-focused tests for the new DTOs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/LootLockerTests/PlayMode/WhiteLabelSignUpFieldsTest.cs | Adds PlayMode + serialization tests for WLL sign-up fields and custom_fields request bodies. |
| Runtime/Game/Requests/WhiteLabelRequest.cs | Introduces DTOs for custom fields + adds WhiteLabelGetSignUpFields request implementation. |
| Runtime/Game/LootLockerSDKManager.cs | Exposes new public API overload for sign-up with custom fields and a new method to fetch sign-up fields. |
| Runtime/Client/LootLockerEndPoints.cs | Adds the new WLL sign-up fields endpoint definition. |
- Removed custom_fields from LootLockerWhiteLabelUserRequest so login requests no longer serialize an unexpected custom_fields field - Created LootLockerWhiteLabelSignUpRequest inheriting from the base user request and carrying custom_fields - Updated both WhiteLabelSignUp overloads to use the signup-specific request type - Fixed @params JSON escaping assertion to match escaped inner quotes - Removed Debug.Log line that printed the full sign-up request (including password) to CI logs - Fixed assert message wording to describe failure instead of success Addresses review comments on PR #481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/lootlocker/index/issues/1630
Description
Add support for the new sign up form endpoint + support newly implemented input of form answers to the sign up endpoint.
Type of change
Testing notes
Automated tests have been added for what is testable, but there's currently no way to set up custom sign up fields from CI so we can not test the feature fully in CI.