Remove Clang && DirectX XFAILs from Texture2D.Load, Texture2D.OperatorIndex, and Texture2D.mips.OperatorIndex tests#1109
Open
Remove Clang && DirectX XFAILs from Texture2D.Load, Texture2D.OperatorIndex, and Texture2D.mips.OperatorIndex tests#1109
Conversation
farzonl
approved these changes
Apr 23, 2026
farzonl
reviewed
Apr 23, 2026
| #--- end | ||
|
|
||
| # Unimplemented: Clang + DX: https://github.com/llvm/llvm-project/issues/101558 | ||
| # XFAIL: DirectX || Metal && Clang |
Member
There was a problem hiding this comment.
You might need to re-run this test I don't think your changes got picked up by the offload CI.
Contributor
Author
There was a problem hiding this comment.
No, it seems the test is failing with gpu-exec: error: Multiple mip levels are not yet supported for DirectX textures. on all the DirectX 12 pipelines.
I need to re-add the XFAIL for DirectX, but it is now passing with Metal.
The issue to track implementation of multiple mip levels in DirectX is: #1039
…. Remove XFAIL on Clang && DirectX
Icohedron
changed the title
Icohedron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#193343 was merged, completing the DirectX backend implementations of the texture load method (llvm/llvm-project#192546) and the texture [] operator (llvm/llvm-project#192558). The
.mips[][]operator also simply lowers to a texture load, so its implementation is also complete.Therefore the tests
test/Feature/Textures/Texture2D.Load.test.yaml,test/Feature/Textures/Texture2D.OperatorIndex.test.yaml, andtest/Feature/Textures/Texture2D.mips.OperatorIndex.test.yamlcan now be enabled for Clang && DirectX.However, only
test/Feature/Textures/Texture2D.Load.test.yamlis expected to pass, as the other two tests require multiple mip level support and therefore will still XFAIL on DirectX due to #1039