Add a descriptor allocator to DX12 backend. Store handles to RTV and DSV and Texture.#1104
Open
manon-traverse wants to merge 1 commit intollvm:mainfrom
Open
Conversation
EmilioLaiso
reviewed
Apr 23, 2026
Contributor
EmilioLaiso
left a comment
EmilioLaiso
left a comment
There was a problem hiding this comment.
LGTM, one small comment about adding unused fields.
Comment on lines
+294
to
+298
| // Staging descriptors, allocated from the device's central non-shader-visible | ||
| // CBV_SRV_UAV heap. A zero ptr means no descriptor. | ||
| D3D12_CPU_DESCRIPTOR_HANDLE SRVHandle = {}; | ||
| D3D12_CPU_DESCRIPTOR_HANDLE UAVHandle = {}; | ||
|
|
Contributor
There was a problem hiding this comment.
Let's add these in the PR that makes use of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small step forward in how descriptors are managed.
This PR aims to store the RTV and DSV descriptors in centralized heaps on the device, using DX12 as intended by having all the descriptors in a shared heap.
In a follow-up step, this same change will also be made to
CBV_SRV_UAVdescriptors.