Skip to content

Rework workflow design to allow opting in to SplitBuild feature, and use Windows-compatible tar options #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bob80905 wants to merge 2 commits into
base: main
Choose a base branch
from
+165 −340
Open

Rework workflow design to allow opting in to SplitBuild feature, and use Windows-compatible tar options #1103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dad02
use windows compatible tar options
bob80905 Apr 20, 2026
7d22916
address Justin post commit feedback
bob80905 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/build-and-test-split-callable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,14 @@ jobs:
shell: bash
run: |
cd $GITHUB_WORKSPACE
tar xf $RUNNER_TEMP/build-artifacts.tar --touch
tar xf $RUNNER_TEMP/build-artifacts.tar
- name: Refresh artifact timestamps
shell: powershell
run: |
# Touch all extracted build outputs so ninja sees them as newer
# than source files and skips rebuilding.
Get-ChildItem -Recurse -File DXC\build\bin, llvm-project\build |
ForEach-Object { $_.LastWriteTime = Get-Date }
Copy link
Copy Markdown
Contributor

@bogner bogner Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this really get away with being windows only?

Copy link
Copy Markdown
Contributor Author

@bob80905 bob80905 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on line 230 we guard this code against macOS runs.
MacOS will not do any of this artifact download / upload stuff, since it is so fast it doesn't need this optimization, and I think this whole thing will be simpler if we exclude MacOS.

Copy link
Copy Markdown
Contributor

@bogner bogner Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my post-commit review here: #1067 (review) - I have some misgivings about these architectural choices.


- name: Setup Windows x64
if: runner.arch != 'ARM64'
Expand Down
Loading