Return SubmitResult from Queue::submit() instead of blocking#1101
Draft
Return SubmitResult from Queue::submit() instead of blocking#1101
SubmitResult from Queue::submit() instead of blocking#1101Conversation
MarijnS95
force-pushed
the
in-flight-command-buffers
branch
from
a57700f to
fafbd2e
Compare
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. Each backend uses its Fence abstraction for GPU synchronization: - Metal: commit() + waitUntilCompleted() - Vulkan: vkQueueSubmit() signaling a timeline semaphore (VulkanFence), then VulkanFence::waitForCompletion() - DX12: ExecuteCommandLists() + Queue::Signal() on the queue-owned DXFence, then DXFence::waitForCompletion() Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
MarijnS95
force-pushed
the
in-flight-command-buffers
branch
from
fafbd2e to
3f84c18
Compare
Change `Queue::submit()` to return `Expected<SubmitResult>` (a fence + signal value pair) instead of blocking until completion. Each backend (Vulkan, DirectX, Metal) now returns its queue fence and counter value, and callers explicitly wait via `SubmitResult::waitForCompletion()` before reading back results. This allows command buffers submitted between the first and last submit to remain in-flight on the GPU without host-side synchronization. - Vulkan: `cleanup()` waits on the queue fence for error-path safety - DirectX: tile mapping sync reuses the queue's `SubmitFence` - Metal: `MTLQueue` gains a `SharedEvent` fence; the last command buffer in each batch encodes a signal on it Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
MarijnS95
force-pushed
the
in-flight-command-buffers
branch
from
3f84c18 to
b1b3f4e
Compare
Queue::submit() takes ownership of command buffers, but their destructors free backend resources (VkCommandPool, ID3D12CommandAllocator) that the GPU may still be reading from. Track in-flight batches per queue, tagged with their fence signal value, and non-blockingly query fence progress at the start of each submit to release completed batches. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
MarijnS95
force-pushed
the
in-flight-command-buffers
branch
from
9b4fc60 to
2f5662a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1057
Change
Queue::submit()to returnExpected<SubmitResult>(a fence + signal value pair) instead of blocking until completion. Each backend (Vulkan, DirectX, Metal) now returns its queue fence and counter value, and callers explicitly wait viaSubmitResult::waitForCompletion()before reading back results.This allows command buffers submitted between the first and last submit to remain in-flight on the GPU without host-side synchronization.
cleanup()waits on the queue fence for error-path safetySubmitFenceMTLQueuegains aSharedEventfence; the last command buffer in each batch encodes a signal on it🤖 Generated with Claude Code