Skip to content

Remove XFAILs from tests related to resources in structs #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hekota wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove XFAILs from tests related to resources in structs #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/Feature/ResourcesInStructs/array-of-structs-with-res.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
3 changes: 0 additions & 3 deletions test/Feature/ResourcesInStructs/res-array-of-matrix-in-struct.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# Unimplemented https://github.com/microsoft/DirectXShaderCompiler/issues/8301
# XFAIL: Vulkan && DXC

Expand Down
8 changes: 0 additions & 8 deletions test/Feature/ResourcesInStructs/res-in-struct-mix.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class G : F {
E e;
StructuredBuffer<int> SrvBuf2;
RWBuffer<int> UavBuf2;
uint n;
Copy link
Copy Markdown
Member Author

@hekota hekota Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this because:

  1. Vulkan does not support structs with resource and non-resource fiels.
  2. For Clang-DirectX this creates a $Globals constant buffer that is not used. Because it is not mapped to a CBV resource, the offloat test runner crashes during PSO creation. [HLSL][DirectX] Remove unused constant buffers from module llvm-project#192524.

};

RWStructuredBuffer<int4> Out : register(u0);
Expand Down Expand Up @@ -119,16 +118,9 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# Bug https://github.com/llvm/offload-test-suite/issues/642
# XFAIL: Metal

# Vulkan does not support global structures with buffers or structures
# containing both resources and non-resources.
# UNSUPPORTED: Vulkan

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
3 changes: 0 additions & 3 deletions test/Feature/ResourcesInStructs/res-in-struct-simple-array.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# Unimplemented https://github.com/llvm/offload-test-suite/issues/305
# XFAIL: Metal

Expand Down
3 changes: 0 additions & 3 deletions test/Feature/ResourcesInStructs/res-in-struct-simple-one.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
5 changes: 0 additions & 5 deletions test/Feature/ResourcesInStructs/res-of-matrix-in-struct.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,9 @@ DescriptorSets:
...
#--- end

# Unimplemented https://github.com/llvm/wg-hlsl/issues/367
# XFAIL: Clang

# Unimplemented https://github.com/microsoft/DirectXShaderCompiler/issues/8302
# XFAIL: Vulkan && DXC


# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o

Loading