[CMake] Add TEST_SUITE_SAMPLE_PROFILE_USE for sample-based PGO#380
Open
[CMake] Add TEST_SUITE_SAMPLE_PROFILE_USE for sample-based PGO#380
TEST_SUITE_SAMPLE_PROFILE_USE for sample-based PGO#380Conversation
TEST_SUITE_SAMPLE_PROFILE_USE for sample-based PGO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for sample profile support (
-fprofile-sample-use) to the test suite with two new CMake flags:TEST_SUITE_SAMPLE_PROFILE_USE=On|Off: enables sample profile use.TEST_SUITE_SAMPLE_PROFILE_DIR=<path>: a directory containing<target>.spgosample profile files.Unlike instrumentation PGO which requires a two-phase generate + use workflow, sample profiles are collected externally, and the collection method various widely between platforms. For each benchmark target, the build system looks for
<dir>/<target>.spgoand passes-fprofile-sample-use=<path>to the compile flags. In case, the target does not have an associated sample profile, an warning is emitted.