Feat: Black (AMOLED) theme - #17
Open
xMate420x wants to merge 5 commits into
Open
Conversation
Owner
|
I'm a huge fan of this idea, I too love a fully black amoled-compatible theme. The reason I've not incorporated such a theme already is simply because it doesn't always look as nice on a desktop, which I feel is likely the main platform that pihole would be used from. Having said that, it'd not be hard to make a theme selection option available in the installer. What are your thoughts on that? Though keep in mind there's a lot more things that I need to rewrite before doing that (I need to submit some PR's to the official pihole repo in order to remove some statically-themed elements) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think a fully black theme is really useful for AMOLED devices, as it can save a lot on battery, and in my opinion looks better than regular dark.
I will also write a separate installer for it later today.