Adding support for Frame Metadata#664
Open
chenosaurus wants to merge 3 commits into
Open
Conversation
chenosaurus
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ Track SID not updated after local_track_republished, causing stale track.sid (livekit-rtc/livekit/rtc/room.py:744-748)
When the local_track_republished handler fires during a full reconnect, it updates republished._info (the publication info) with the new server-assigned SID but does not update republished._track._info.sid. During initial publish_track (livekit-rtc/livekit/rtc/participant.py:768), the track SID is explicitly synced with track._info.sid = track_publication.sid. After a full reconnect, publication.sid returns the new SID but publication.track.sid still returns the old SID. This can cause a KeyError if user code passes the stale track.sid to unpublish_track(), since the publication dict is now keyed by the new SID.
View 5 additional findings in Devin Review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/local_videoto demonstrate usage.