Add room_id to SimulationRun.Job#1559
Open
Ocupe wants to merge 3 commits into
Open
Conversation
Lets consumers link a simulated session to its corresponding room session rather than only surfacing the simulation job id. Backend needs a follow-up to populate the field; existing readers default to "" until then.
🦋 Changeset detectedLatest commit: cd68259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Aligns with the existing room_id naming used elsewhere in this proto (e.g. Scenario.CreateFromSession.Request).
Ocupe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the simulation job structure, enabling consumers to link a simulated session directly to its corresponding room session. The primary change is the addition of a new
room_idfield to theSimulationRun.Jobstructure, along with the necessary supporting code and documentation.Simulation Job Structure Enhancements:
room_idfield to theSimulationRun.Jobstruct inlivekit_agent_simulation.pb.goto store the ID of the room session associated with the job. This allows consumers (such as dashboards) to reference the room session directly.GetRoomIdmethod for theSimulationRun.Jobstruct to provide safe access to the newroom_idfield.Protobuf and Documentation Updates:
room_idfield, ensuring proper serialization and code generation. [1] [2] [3]room_idand its purpose for consumers. (.changeset/agent-sim-job-room-session-id.md)