Skip to content

fix: remove deepin prefix from Chinese translations in desktop file - #57

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n
Jul 16, 2026
Merged

fix: remove deepin prefix from Chinese translations in desktop file#57
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n

Conversation

@add-uos

@add-uos add-uos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。

Summary by Sourcery

Bug Fixes:

  • Correct Chinese desktop file translations by removing unnecessary "深度"/"deepin"/"Deepin" prefixes from Name and Comment.

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment
fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。
@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates Chinese translations in the deepin-picker.desktop file by removing the "深度"/"deepin"/"Deepin" branding prefix from Name and Comment fields for zh_CN, zh_HK, and zh_TW entries, keeping the rest of the desktop file unchanged.

File-Level Changes

Change Details Files
Remove the "深度"/"deepin"/"Deepin" prefix from Chinese Name and Comment translations in the desktop file.
  • Update zh_CN Name translation to omit the brand prefix while retaining the application name meaning.
  • Update zh_CN Comment translation to omit the brand prefix and keep the description intact.
  • Update zh_HK Name and Comment translations to remove the brand prefix consistently.
  • Update zh_TW Name and Comment translations to remove the brand prefix consistently.
  • Verify that only translation strings changed and no desktop entry keys or non-Chinese locales were modified.
deepin-picker.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码实现了桌面快捷方式中文案的去品牌化规范,无任何缺陷
逻辑正确且完全符合规范,满分通过

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

deepin-picker.desktop文件第118-120行,键值对格式标准,无多余空格或非法字符,完全符合freedesktop.org桌面入口文件语法规范
建议:保持当前格式即可

  • 2.代码质量(符合规范)✓

将简繁体及香港地区的应用名称统一修改为“取色器”,有效去除了品牌前缀,提升了系统UI的统一性与规范性
建议:继续保持此类配置文案的统一管理

  • 3.代码性能(无性能问题)✓

纯静态配置文件修改,仅在桌面环境加载时解析一次,不产生任何运行时性能开销
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
纯文本国际化文案修改,不涉及任何代码执行、变量解析、命令调用或敏感信息处理,无攻击面
建议:无

■ 【改进建议代码示例】

--- a/deepin-picker.desktop
+++ b/deepin-picker.desktop
@@ -115,7 +115,7 @@ Name[lo]=Deepin ເລືອກສີ
-Name[zh_CN]=深度取色器
-Name[zh_TW]=Deepin 取色器
-Name[zh_HK]=Deepin 取色器
+Name[zh_CN]=取色器
+Name[zh_TW]=取色器
+Name[zh_HK]=取色器

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 2b51119 into linuxdeepin:master Jul 16, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants