fix(monitor): add support for kSpecialType10 computer type#704
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
69a0e2f to
09bd43c
Compare
Add support for kSpecialType10 in CPU frequency display, monitor overview info, and EDID parsing. Fix syntax error in height comparison. 添加 kSpecialType10 计算机类型支持,涵盖 CPU 频率显示、显示器概览信息和 EDID 解析。修复高度比较语法错误。 Log: 添加 kSpecialType10 计算机类型支持 PMS: BUG-369547 Influence: kSpecialType10 计算机类型的 CPU 频率显示和显示器信息解析逻辑正确,修复了 EDIDParser 的语法错误。
09bd43c to
27ff76e
Compare
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // 建议在Common类中提供静态集合或辅助函数来简化多重枚举判断
// 例如在 commonfunction.h 中:
class Common
{
public:
static const QSet<SpecialComType> &specialMonitorTypes() {
static const QSet<SpecialComType> types = {
kSpecialType6, kSpecialType7, kSpecialType9, kSpecialType10
};
return types;
}
};
// 在 DeviceMonitor.cpp 中简化判断:
if (Common::specialMonitorTypes().contains(Common::specialComType)) {
// ...
}
// 在 EDIDParser.cpp 中保持守卫条件:
if (Common::specialComType == Common::kSpecialType7 ||
Common::specialComType == Common::kSpecialType10) { // special task:378963
if (m_Width == 300 && m_Height == 200) {
m_Width = 296;
m_Height = 197;
}
} |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
6db5c14
into
linuxdeepin:develop/eagle
Add support for kSpecialType10 in CPU frequency display, monitor overview info, and EDID parsing. Fix syntax error in height comparison.
添加 kSpecialType10 计算机类型支持,涵盖 CPU 频率显示、显示器概览信息和 EDID 解析。修复高度比较语法错误。
Log: 添加 kSpecialType10 计算机类型支持
PMS: BUG-369547
Influence: kSpecialType10 计算机类型的 CPU 频率显示和显示器信息解析逻辑正确,修复了 EDIDParser 的语法错误。