Skip to content

chore: Update version to 6.0.68#703

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Jul 9, 2026
Merged

chore: Update version to 6.0.68#703
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
  • update version to 6.0.68

log: update version to 6.0.68

Summary by Sourcery

Update Debian packaging metadata for release 6.0.68.

Build:

  • Bump packaged application version to 6.0.68 in Debian changelog.

Chores:

  • Align project versioning with Debian package release 6.0.68.

- update version to 6.0.68

log: update version to 6.0.68
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 6.0.68
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai

sourcery-ai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the project’s Debian package version reference to 6.0.68 in the changelog to reflect the new release.

File-Level Changes

Change Details Files
Update Debian package version metadata to 6.0.68.
  • Modify the latest entry in the Debian changelog to set the version to 6.0.68.
  • Adjust associated log/message text in the changelog to mention version 6.0.68.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:85分

■ 【总体评价】

代码实现了设备显示器尺寸和基本信息的条件展示,但存在严重的魔数滥用和代码重复问题
逻辑正确但因可读性差和重复代码扣15分

■ 【详细分析】

  • 1.语法逻辑(基本正确)✓

代码在 DeviceMonitor.cpp 的第359-368行和385-387行使用了标准的 C++ if-else 结构,语法完整,能够正常编译运行,不存在语法错误。
潜在问题:无
建议:无

  • 2.代码质量(较差)✕

代码中多次使用魔数(如6、7、5)对 Common::specialComType 进行判断,缺乏常量或枚举定义,可读性极差。第360行和第365行存在完全相同的条件判断 Common::specialComType == 6 || Common::specialComType == 7,违反了 DRY 原则,增加了维护成本。
潜在问题:魔数含义不明确,后续开发者难以理解业务逻辑;重复代码在修改时容易遗漏。
建议:将魔数替换为具名常量或枚举;根据 changelog 提示,使用 Common::isHwPlatform() API 替换魔数判断;提取重复判断逻辑。

  • 3.代码性能(无性能问题)✓

代码仅涉及简单的整数比较和字符串赋值操作,时间复杂度为 O(1),没有循环或复杂的系统调用,对程序性能没有影响。
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
代码仅涉及内部设备类型的数值判断和局部字符串处理,未涉及外部输入解析、文件操作或系统命令执行,不存在可利用的安全漏洞和攻击面。

  • 建议:无

■ 【改进建议代码示例】

--- a/deepin-devicemanager/src/DeviceManager/DeviceMonitor.cpp
+++ b/deepin-devicemanager/src/DeviceManager/DeviceMonitor.cpp
@@ -359,12 +359,12 @@
     if (Common::isShowScreenSize()) {
-        if (Common::specialComType == 6 || Common::specialComType == 7) {
+        if (Common::isHwPlatform()) {
             ov = QString("(%1)").arg(m_ScreenSize);
         }
     } else {
-        if (Common::specialComType == 6 || Common::specialComType == 7) {
+        if (Common::isHwPlatform()) {
             ov = "";
         }
     }
@@ -385,7 +385,7 @@
     // 添加基本信息
-    if (Common::specialComType != 6 && Common::specialComType != 5) {
+    if (!Common::isHwPlatform() && Common::specialComType != SPECIAL_COM_TYPE_5) {
         addBaseDeviceInfo("Name", m_Name);
     }

@lzwind lzwind merged commit 2de4121 into linuxdeepin:master Jul 9, 2026
21 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.68
  • Tag SHA: a3d70dcd611922d00a08264d3234b232034a0901
  • Commit SHA: 2de412165178f2d128f8fbb4f1d9a99767219b97
  • Tag Message:
    Release deepin-devicemanager 6.0.68
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants