fix: add ConcatScreenName property for multi-screen display#1170
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Hi @52cyb. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Added new `ConcatScreenName` field to Manager struct to store the name of the current concatenated screen 2. Refactored `applyConcatScreen` and `removeConcatScreen` to use new `setConcatScreenEnabled` helper 3. Created `setConcatScreenEnabled` method that sets both `ConcatScreenEnabled` and `ConcatScreenName`, emits property changes only when state actually changes 4. Removed direct property emission in favor of centralized change detection Log: Added ConcatScreenName property to display manager for multi-screen identification Influence: 1. Verify that ConcatScreenEnabled property emits changes correctly when enabling/disabling concatenated screen mode 2. Test that ConcatScreenName property is updated and emitted with the correct screen name 3. Ensure no redundant property emissions occur when state hasn't changed 4. Test backward compatibility with existing display management workflows 5. Verify that removing concatenated screen correctly clears the ConcatScreenName feat: 添加多屏显示的 ConcatScreenName 属性 1. 在 Manager 结构体中新增 ConcatScreenName 字段，用于存储当前合并屏幕的 名称 2. 重构 applyConcatScreen 和 removeConcatScreen 方法，改用新的 setConcatScreenEnabled 辅助函数 3. 创建 setConcatScreenEnabled 方法，同时设置 ConcatScreenEnabled 和 ConcatScreenName 属性，仅在状态实际变化时发送属性变更信号 4. 移除直接的属性发送逻辑，改用集中式变更检测 Log: 为显示管理器新增 ConcatScreenName 属性，用于多屏识别 Influence: 1. 验证启用/禁用合并屏幕模式时 ConcatScreenEnabled 属性是否正确发送变更 信号 2. 测试 ConcatScreenName 属性是否随正确屏幕名称更新并发送信号 3. 确保状态未变化时不会产生冗余属性发送 4. 测试与现有显示管理功能的向后兼容性 5. 验证移除合并屏幕后是否正确清空 ConcatScreenName PMS: BUG-362687
3 participants
ConcatScreenNamefield to Manager struct to store the name of the current concatenated screenapplyConcatScreenandremoveConcatScreento use newsetConcatScreenEnabledhelpersetConcatScreenEnabledmethod that sets bothConcatScreenEnabledandConcatScreenName, emits property changes only when state actually changesLog: Added ConcatScreenName property to display manager for multi-screen identification
Influence:
feat: 添加多屏显示的 ConcatScreenName 属性
Log: 为显示管理器新增 ConcatScreenName 属性，用于多屏识别
Influence:
PMS: BUG-362687