Edit links already saved from the popup - #147
Open
arqueon wants to merge 1 commit into
Open
Conversation
arqueon
marked this pull request as ready for review
July 29, 2026 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SavetoUpdateand send aPUTto the existing link IDwwwand trailing-slash URL variants that Linkwarden treats as duplicatesWhy
The extension currently calls the search API only to obtain
trueorfalse. It discards the matching link ID and therefore cannot update the saved record.Immediately after a new link is created, the extension queries the search index again to update its badge. The index can lag behind the write, so the popup may temporarily return to
Saveand allow a duplicate capture even though the link already exists.User impact
After saving a page, reopening the popup or reloading the tab keeps the page marked as saved. The popup shows the existing metadata and lets the user update the same Linkwarden record instead of creating another one.
The recent-link cache is scoped by Linkwarden instance, limited to 50 entries, and expires after 15 minutes. The server remains the durable source of truth.
Validation
npm testnpx tsc --noEmitnpm run buildnpm run build:safarigit diff --checkUpdate; saved metadata is populated; updating does not duplicate the record; tab reload preserves the badge and edit modeThis is intentionally separate from #146, which remains focused on tag selection UX.