Skip to content

Bump linkerd/namerd docker image version#257

Open
nfisher wants to merge 5 commits into
linkerd:masterfrom
nfisher:master
Open

Bump linkerd/namerd docker image version#257
nfisher wants to merge 5 commits into
linkerd:masterfrom
nfisher:master

Conversation

@nfisher

@nfisher nfisher commented Oct 19, 2019

Copy link
Copy Markdown

At a high level this PR is making a few changes:

  1. bumping linkerd to 1.7.0.
  2. fixing the broken hello-world.yml.
  3. make a single RBAC YAML file that can be applied to a cluster without a separate create NS command (arguably could be done for each class of config). Focused here because few modern clusters seem to exist without it.

@cpretzer

Copy link
Copy Markdown
Contributor

thanks @nfisher I'll go through a couple of tests and make things run as expected. Then we merge!

@nfisher

nfisher commented Oct 21, 2019

Copy link
Copy Markdown
Author

@cpretzer think it also needs to be synced with the docs sometimes the docs reference world and the name is world-v1 as an example.

@nfisher

nfisher commented Oct 21, 2019

Copy link
Copy Markdown
Author

I'll submit a servicemesh-rbac.yml so there's a fully functioning RBAC example.

Currently the only example is copy and paste from this blog post with only the service account/role binding, etc in the example repo:
https://linkerd.io/2017/07/24/using-linkerd-kubernetes-rbac/

@nfisher nfisher changed the title [WIP] Bump linkerd/namerd docker image version Bump linkerd/namerd docker image version Oct 25, 2019

@adleong adleong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick spot checking and all of these appear to correctly start up with version 1.7.0

@cpretzer cpretzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look straightforward. Thanks @nfisher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants