Improve read and grep long-line output#278
Merged
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #230
Contributor
Author
Working session summaryImplemented issue #230 and updated PR #278: #278 Changes made:
Verification:
CI investigation logs were preserved outside the repo at Research sources used: ripgrep manpage, grep-printer JSON docs, ripgrep guide, and ripgrep issue #1451. This summary was automatically extracted from the AI working session output. |
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (407.6K + 8.2M cached) input tokens, 54.1K output tokens, $14.694795 cost 🤖 Models used:
📎 Log file uploaded as Gist (6703KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Contributor
Author
✅ Ready to mergeThis pull request is now ready to be merged:
Monitored by hive-mind with --auto-restart-until-mergeable flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
Summary
readto summarize long files with first/last line ranges by default and supportcolumnOffset/columnLimitfor selected lines.grepoutput to keep long matching lines bounded while preserving the matching segment with omitted-column markers.docs/case-studies/issue-230with raw GitHub artifacts, online/library research, extracted requirements, alternatives, and verification notes.Reproduction and Coverage
The regression tests create long files and long single-line fixtures that reproduce the issue behavior:
readnow returns first and last line ranges with... [omitted lines X..Y] ...;readon one long line returns first columns, omitted-column range, and last columns;columnOffset/columnLimitreturns the requested column window;grepon a long line containingivu-modal-header{cursor:move}returns the match-focused snippet instead of hiding or dumping the whole line.Verification
Observed locally: JS focused tests passed, JS check passed, full JS suite passed with 609 pass / 4 todo / 0 fail, Rust focused tests passed, and full Rust suite passed.