Skip to content

Rust can parse Very Long nine tails since 1.55.0#17

Open
nabijaczleweli wants to merge 1 commit into
likebike:masterfrom
nabijaczleweli:1.55.0
Open

Rust can parse Very Long nine tails since 1.55.0#17
nabijaczleweli wants to merge 1 commit into
likebike:masterfrom
nabijaczleweli:1.55.0

Conversation

@nabijaczleweli

@nabijaczleweli nabijaczleweli commented Nov 2, 2021

Copy link
Copy Markdown

False negative in the test, nbd

@keszybz

keszybz commented Nov 17, 2021

Copy link
Copy Markdown

I think should be conditionalized on rust version. With rust 1.54.0 this test now fails.

@nabijaczleweli

nabijaczleweli commented Nov 17, 2021

Copy link
Copy Markdown
Author

Yeah, fair. cfg(version) is experimental, so I effectively inlined the rustc_version crate, and pick the old path before rustc 1.55

@keszybz

keszybz commented Nov 18, 2021

Copy link
Copy Markdown

I tested this with rust-1.54.0-1.fc33.x86_64 and cargo-1.56.1-1.fc33.x86_64 and the tests pass in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants