fix: return list of location search results in weather tool#97
Merged
Conversation
dupontgu
approved these changes
Jul 17, 2026
| label = "Authenticator" | ||
| versionCode = 1 | ||
| versionName = "1.0" | ||
| versionCode = 2 |
Contributor
There was a problem hiding this comment.
This just reminded me - let's make sure we're publishing tags/releases from the exact commits that we cut the example tools from.
github-actions Bot
pushed a commit
to tyleryancey/light-tools
that referenced
this pull request
Jul 23, 2026
Upstream changes: d502bca Merge pull request lightphone#118 from lightphone/fix/semver-versionname cd621b7 Merge pull request lightphone#117 from lightphone/builder-ci c0cf471 fix: enforce semver for tool versionName 29911b2 filter on tags 809c0d8 add circleci config 5124ab6 Merge pull request lightphone#112 from lightphone/fix/icons 92b3b20 Merge pull request lightphone#97 from lightphone/fix/weather-tool-search bb87390 use light api proxy 9cd076f delete redundant icons, fix ugly ones eb5b6a6 fix: return list of location search results in weather tool
tyleryancey
added a commit
to tyleryancey/light-tools
that referenced
this pull request
Jul 23, 2026
Upstream changes: 464b414 Merge upstream lightphone/light-sdk main c43875c ci(sync): merge from upstream instead of ff-only, add chess, summarize syncs d502bca Merge pull request lightphone#118 from lightphone/fix/semver-versionname cd621b7 Merge pull request lightphone#117 from lightphone/builder-ci c0cf471 fix: enforce semver for tool versionName 29911b2 filter on tags 809c0d8 add circleci config 5124ab6 Merge pull request lightphone#112 from lightphone/fix/icons 92b3b20 Merge pull request lightphone#97 from lightphone/fix/weather-tool-search bb87390 use light api proxy 9cd076f delete redundant icons, fix ugly ones eb5b6a6 fix: return list of location search results in weather tool Conflict resolution: kept chess's lighttool.toml identity (permissions = []) and bumped versionName to semver 0.1.0 for the new builder enforcement; kept deletion of the sample HomeScreen.kt that chess had replaced. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the open meteo geocoding api doesn't accept strings that include administrative region or country (e.g. searching for "Camden, New Jersey" doesn't work), we have to return a list of results to allow for user selection.