nitpicky kotlin/mvvm stuff (audio PR feedback)#123
Merged
Conversation
dupontgu
commented
Jul 24, 2026
| private var player: LightAudioPlayer? = null | ||
| private var stateJob: Job? = null | ||
|
|
||
| fun attachAudio(value: LightAudio) { |
Contributor
Author
There was a problem hiding this comment.
The main change to these viewmodels is I got rid of the attachAudio calls. LightAudio can be passed into the constructor in all these cases so you can reduce the number of nullable fields and get rid of initialization step inside the @Composables (which can get wonky with recomposition)
dupontgu
commented
Jul 24, 2026
| val newPlayer = value.newPlayer() | ||
| player = newPlayer | ||
| stateJob = viewModelScope.launch { | ||
| launch { newPlayer.positionMs.collect(positionMs::emit) } |
Contributor
Author
There was a problem hiding this comment.
can just pass a reference to the player's StateFlow's directly rather than pipe them through a new one
dupontgu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to test in the morning before merging, but I have Gus' permission to do so.