SMAA: Fix color edge detection - #194
Merged
Merged
Conversation
Fix incorrect calculation of local contrast adaption in color edge detection This is the fix from PR iryoku/smaa#11
Collaborator
|
Interesting. I don't see any refutation on the PR, but it's never been merged. Is there a reason upstream doesn't want it? |
Author
|
I think it's just down to iryoku not having the time and motivation to be a maintainer for it. It seems like he hasn't interacted with anything on the repo in several years. Not that that's a problem, the thing is so well done that it had only two minor bugs found in the last 8 years, AFAICT. He keeps developing new techniques on top of SMAA in private projects, though. Just look at his slide deck on Filmic SMAA. Quite entertaining stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMAA: Fix color edge detection
Fix incorrect calculation of local contrast adaption in color edge detection
This is the fix from PR iryoku/smaa#11
I decided to port this fix as I was able in my tests to gather image evidence showing top/left edges that were obviously being missed by Color Edge Detection, that are fixed by the changes in this commit. Although the problem affects a lot of edges, it is rarely so obvious like in this image.