Skip to content

AnnotSV ranking criteria: missing closing paren in 2B (loss) explanation #341

Description

@hkeward

Since v3.5.6 which allowed weights to be customized (this commit), the AnnotSV_ranking_criteria output column contains an unbalanced parenthesis for anything with 2B (loss).

Here is a before and after from the version I was using prior to attempting to upgrade to v3.5.10:

# v3.5.2
2B (cf po_P_loss_source, HI, OMIM_morbid, +0.00);

# v3.5.10
2B (cf po_P_loss_source, HI, OMIM_morbid, +0.00;

This line appears to be the culprit. (other ACMG criteria that were made configurable have the closing paren - e.g. just a few lines above for 2A).

I think this would fix the issue:

--- a/share/tcl/AnnotSV/AnnotSV-ranking.tcl
+++ b/share/tcl/AnnotSV/AnnotSV-ranking.tcl
@@ proc SVrankingLoss  (~line 161) @@
                 # 2B. Partial overlap of a known pathogenic Loss SV (default +0.00)
-                set g_rankingExplanations($AnnotSV_ID,2B) "2B (cf po_P_loss_source, HI, OMIM_morbid, +$g_rankingCriteria(2B_Loss);"
+                set g_rankingExplanations($AnnotSV_ID,2B) "2B (cf po_P_loss_source, HI, OMIM_morbid, +$g_rankingCriteria(2B_Loss));"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions