Normalize custom maps in SL parametrizations#53
Merged
Conversation
lezcano
force-pushed
the
review/sl-custom-maps
branch
from
4a28f47 to
ba85c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLsingular-value map in the log domain(forward, inverse)map pairsWhy
Previously, only the built-in
"softplus"map was normalized. Custom positive maps could therefore produce matrices outsideSL(n)despite being accepted by the public API.Validation
pytest -s --tb=short -n8 test/test_sl.py60 passed, 1 skipped