fix: handle Telegram poll conflicts and ngrok dev URLs#43
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Summary
.devtunnel URLs in tunnel output parsingRoot cause
OpenCode can initialize the plugin twice in the same process, which starts duplicate Telegram getUpdates loops. Telegram rejects the duplicate long poll with a 409 conflict, but the plugin treated it as a generic transient polling failure and retried indefinitely. The ngrok tunnel extractor also only matched
.appngrok domains, so.ngrok-free.devURLs were ignored.Validation
bun test src/infra/tunnel/__tests__/url-extractor.test.tsfailed before the regex change and passes afterbun test src/notifications/channels/telegram/index.test.tsfailed before the poll conflict handling and passes afterbun run typecheckbun run lint(0 errors; existing warnings remain)bun test(733 pass)bun run prepublishOnlygit diff --check