Skip to content

Lock EASE solving to work around parallel bug#1152

Merged
mdekstrand merged 2 commits into
lenskit:mainfrom
mdekstrand:fix/ease-parallel
Jul 15, 2026
Merged

Lock EASE solving to work around parallel bug#1152
mdekstrand merged 2 commits into
lenskit:mainfrom
mdekstrand:fix/ease-parallel

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

Torch has a race condition initializing Choleseky solver, so this wraps our call to it in a lock.

@mdekstrand mdekstrand added this to the 2026.3 milestone Jul 14, 2026
@mdekstrand mdekstrand self-assigned this Jul 14, 2026
@mdekstrand mdekstrand added the components LensKit recommendation components label Jul 14, 2026
@mdekstrand mdekstrand merged commit 824faed into lenskit:main Jul 15, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LensKit Development Jul 15, 2026
@mdekstrand mdekstrand deleted the fix/ease-parallel branch July 15, 2026 16:45
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (e622c4e) to head (824faed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files         258      258           
  Lines       17313    17316    +3     
=======================================
+ Hits        15503    15506    +3     
  Misses       1810     1810           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components LensKit recommendation components

Projects

Development

Successfully merging this pull request may close these issues.

1 participant