This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Fix Knot Behavior, Interaction Safety, and Cleanup Logic#110
Open
evanbones wants to merge 6 commits into
Open
Conversation
Owner
|
Thank you for taking the time to work on it. |
|
🙏 |
Author
|
Some of these changes are pretty opinionated, so feel free to just cherrypick any changes you'd like, but they're also implemented in a multiloader fork I made of the mod |
Owner
|
Wow, you made a multiloader version‽ Why did you not make that a PR? |
Author
|
It was pretty close to a full rewrite since the mappings had to be changes to mojamps and I made a lot of much more opinionated changes like increasing max chain distance to 128, but if you'd like I'd be happy to take down my fork and maintain a separate multiloader version? Or if you want to just cherry pick the multiloader logic from my fork? Up to you really |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm open to making any changes if you'd like, as some of these things could be considered major behaviour changes. Let me know!