Add a generic DS402 drive class#395
Open
leducp wants to merge 1 commit into
Open
Conversation
leducp
force-pushed
the
ds402_generic_drive
branch
from
3b0f6df to
ff14ed8
Compare
leducp
force-pushed
the
ds402_generic_drive
branch
from
ff14ed8 to
3978e70
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3978e70 |
trns1997
reviewed
May 30, 2026
| @@ -0,0 +1,7 @@ | |||
| if (PIKEOS) | |||
Collaborator
There was a problem hiding this comment.
do we want to continue pike os support? I am not sure we have the material to validate its working
trns1997
reviewed
May 30, 2026
| bus.finalizeDatagrams(); | ||
| bus.processAwaitingFrames(); | ||
| } | ||
| catch (...) {} |
Collaborator
There was a problem hiding this comment.
hmmm this should throw no?
trns1997
reviewed
May 30, 2026
| if (out_ != nullptr) | ||
| { | ||
| out_->control_word = control::word::DISABLE_VOLTAGE; | ||
| out_->target_position = 0; |
Collaborator
There was a problem hiding this comment.
why set to 0? I think this should keep last position like we do in attach
trns1997
reviewed
May 30, 2026
| catch (std::exception const& e) | ||
| { | ||
| std::cerr << "[" << i << "] " << e.what() << std::endl; | ||
| continue; |
Collaborator
There was a problem hiding this comment.
shouldn't we drive.update() before continue? Do you not want to refresh even if there is a problem?
trns1997
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #396