[19.0][MIG] l10n_it/l10n_it_edi: rename folded-module xmlids#87
Open
dnplkndll wants to merge 3 commits into
Open
[19.0][MIG] l10n_it/l10n_it_edi: rename folded-module xmlids#87dnplkndll wants to merge 3 commits into
dnplkndll wants to merge 3 commits into
Conversation
dnplkndll
force-pushed
the
19.0-mig-l10n-it-family
branch
3 times, most recently
from
fc816ab to
a410085
Compare
dnplkndll
force-pushed
the
19.0-mig-l10n-it-family
branch
3 times, most recently
from
f2c8de7 to
9882f43
Compare
l10n_it_edi_withholding folds into l10n_it (10 tax-report records) and l10n_it_edi_ndd folds into l10n_it_edi (access rule + 22 document-type records). Both move ir_model_data ownership via openupgrade.rename_xmlids in pre-migration so customer FKs to the legacy records survive. apriori already declares the module folds.
base's update_module_names(merge_modules=True) rewrites the folded modules' ir_model_data BEFORE these scripts run: the withholding records already sit under l10n_it_edi (sources fixed accordingly), and the ndd records already land at their final l10n_it_edi names (script was a silent no-op; removed).
The 2026-05 annual-report fix converted 4 VL lines' aggregation_formula shorthand to explicit expression records; shorthand rows have no ir_model_data, so the 19.0 load created a duplicate balance expression on the preserved line (UniqueViolation caught by the enriched gate).
dnplkndll
force-pushed
the
19.0-mig-l10n-it-family
branch
from
9882f43 to
ef2bbd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Italian-localization module folds in 19.0, handled via
openupgrade.rename_xmlidsin pre-migration so customer FKs to the legacy records survive a fresh install:account.tax.tag_idspointing at the withholding line definitions would otherwise orphan.l10n_it.document.typerecords (ids 01-09, 16-28).apriori.renamed_modulesalready declares both folds; this PR moves the ir_model_data ownership without touching res_ids. Not in the lab seed — gated by the OCA migration job + enriched fork test.