[ADD] l10n_fr: cleanup obsolete res.partner.siret + orphan form view#73
Open
dnplkndll wants to merge 3 commits into
Open
[ADD] l10n_fr: cleanup obsolete res.partner.siret + orphan form view#73dnplkndll wants to merge 3 commits into
dnplkndll wants to merge 3 commits into
Conversation
dnplkndll
force-pushed
the
19.0-fix-l10n-fr-cleanup
branch
4 times, most recently
from
65392a5 to
8afe465
Compare
dnplkndll
force-pushed
the
19.0-fix-l10n-fr-cleanup
branch
3 times, most recently
from
ab89c28 to
f870e11
Compare
dnplkndll
force-pushed
the
19.0-fix-l10n-fr-cleanup
branch
3 times, most recently
from
39feb8d to
fd1b1d7
Compare
The 19.0 replacement for the dropped res.partner.siret is core company_registry (l10n_fr_pdp validates SIREN/SIRET on it); without the copy real identifiers strand in an orphan column. Also drop the ineffective field-xmlid delete (the helper can't unlink non-manual fields; the module update prunes the row itself).
dnplkndll
force-pushed
the
19.0-fix-l10n-fr-cleanup
branch
from
fd1b1d7 to
2935812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration work on the ledoent/OpenUpgrade fork (internal review). Rebased onto current 19.0.
The 18.0 l10n_fr module added res.partner.siret (a French SIRET tax
identifier) plus a partner form inheritance view (res_partner_form_l10n_fr)
that exposed it. Both are DEL per upgrade_analysis.txt:
res.partner.siret (char) : DEL
ir.ui.view: res_partner_form_l10n_fr : DEL
The script directory previously contained only the auto-generated
upgrade_analysis.txt. The migration relied on Odoo's standard upgrade flow
to clean up the DEL field and DEL view. That doesn't actually prune them —
the stale ir_model_fields row and orphan view (with arch_db retaining
) survive, and trip cross-cutting view validation
when later modules' data XML loads (reproduced on a fresh 18 → 19 install
with the loyalty / hr / partner_autocomplete companion fixes applied —
l10n_ae/data/account_tax_report_data.xml:3 then raises 'Field "siret"
does not exist in model "res.partner"').
Add pre-migration cleanup_obsolete_l10n_fr_siret using
openupgrade.delete_records_safely_by_xml_id over both the field xml_id
and the view xml_id, plus a companion upgrade_analysis_work.txt
annotating the analysis blocks.