[OU-FIX] account_edi_ubl_cii: guard reason-code map on column existence#108
Open
dnplkndll wants to merge 1 commit into
Open
[OU-FIX] account_edi_ubl_cii: guard reason-code map on column existence#108dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
force-pushed
the
19.0-fix-account-edi-ubl-cii-column-guard
branch
3 times, most recently
from
fbc6c2a to
a38de98
Compare
Stock 18.0 has no account_tax.ubl_cii_tax_exemption_reason_code (the field shipped only in saas builds before landing in 19.0); the unguarded map_values crashes every standard 18->19 migration with the module installed.
dnplkndll
force-pushed
the
19.0-fix-account-edi-ubl-cii-column-guard
branch
from
a38de98 to
fc51e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock 18.0 never had
account_tax.ubl_cii_tax_exemption_reason_code(saas-only until 19.0), so the unguardedmap_valuesin the merged migration crashes every standard 18→19 migration that has account_edi_ubl_cii installed (it auto-installs with account_edi). Found by the lab's minimal-fixture harness on the refreshed aggregate.OCA-clean single commit off origin/19.0, cherry-pickable upstream.