[FIX] l10n_ae, l10n_at: migrate tax-report lines reused as expressions#100
Open
dnplkndll wants to merge 2 commits into
Open
[FIX] l10n_ae, l10n_at: migrate tax-report lines reused as expressions#100dnplkndll wants to merge 2 commits into
dnplkndll wants to merge 2 commits into
Conversation
dnplkndll
force-pushed
the
19.0-fix-l10n-tax-report-lines
branch
3 times, most recently
from
7b3e973 to
c295543
Compare
dnplkndll
added a commit
that referenced
this pull request
Jun 11, 2026
dnplkndll
force-pushed
the
19.0-fix-l10n-tax-report-lines
branch
3 times, most recently
from
eea68dd to
3d21ced
Compare
19.0 consolidated the VAT tax reports — per-section line entries that were account.report.line in 18.0 are reused as account.report.expression on the merged lines (l10n_ae: 8 xml_ids, l10n_at: 2). The module data load aborts overwriting a line record with expression values, so free those xml_ids in pre-migration; the new expressions are then created cleanly and the superseded 18.0 lines are residual. Both were untriaged upstream (docsource -> Done). Validated: a full 18->19 of a seed with both modules installed clears the ParseError at each and advances past them.
dnplkndll
force-pushed
the
19.0-fix-l10n-tax-report-lines
branch
from
3d21ced to
abaaaf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
19.0 consolidated the country VAT tax reports: per-section line entries that were
account.report.linein 18.0 are reused asaccount.report.expressionon themerged lines. The module data load aborts overwriting a line record with
expression values, so a 18→19 of any DB with these installed fails
-u all.Non-mechanical adaptations worth flagging
pre-migrationfrees the reused xml_ids (l10n_ae: 8, l10n_at: 2) so the 19.0expressions create cleanly; the superseded 18.0 lines are residual. Both were
untriaged upstream (blank docsource →
Done).19.0 relevance
Only exercised when these l10n modules are installed — the OCA migration seed has
them uninstalled, so it wasn't caught upstream. Validated on an all-localizations
seed: both reach their 19.0 versions and the ParseError clears.