fix: replace deprecated pkg_resources with pkgutil.extend_path#124
Open
cortexuvula wants to merge 1 commit into
Open
fix: replace deprecated pkg_resources with pkgutil.extend_path#124cortexuvula wants to merge 1 commit into
cortexuvula wants to merge 1 commit into
Conversation
Use pkgutil.extend_path directly instead of pkg_resources.declare_namespace to eliminate the pkg_resources deprecation warning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. The original code already used pkgutil.extend_path as a fallback for when pkg_resources wasn't available, so this is functionally equivalent.
|
Andre Hugo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
lark_oapi/ws/pb/google/__init__.pyfile triggers a deprecation warning on every import:Solution
Replace
pkg_resources.declare_namespace()withpkgutil.extend_path()directly.The original code already used
pkgutil.extend_pathas a fallback whenpkg_resourceswasn't installed, so this change is functionally equivalent — just removes the deprecated path entirely.Impact
pkgutil.extend_pathserves the same namespace package purposepkg_resourcesremoval