Remove obsolete Comet integration#775
Draft
lanpa wants to merge 2 commits into
Draft
Conversation
Remove the Comet.ml logging integration added in #625: the CometLogger class, the comet_config parameter of SummaryWriter, the per-method log_* forwarding calls, the demo example, and the README section. Historical release notes in HISTORY.rst are kept. Note: SummaryWriter(comet_config=...) now raises TypeError. Co-Authored-By: Claude Fable 5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 87.83% 91.31% +3.47%
==========================================
Files 29 28 -1
Lines 1694 1532 -162
==========================================
- Hits 1488 1399 -89
+ Misses 206 133 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Comet.ml logging integration (added in #625, follow-ups #639/#658), continuing the cleanup of obsolete integrations (visdom in #768, TorchVis in #772).
Changes
tensorboardX/comet_utils.py(CometLogger, 387 lines)examples/demo_comet.pyandscreenshots/comet.giftensorboardX/writer.py:comet_configconstructor parameter and its docstring_get_comet_logger()and the_comet_config/_comet_loggerattributesself._get_comet_logger().log_*()call at the end of all 17add_*methods and the.end()call inclose()encoded_image_stringassignments that existed only to feed CometHISTORY.rstmentions are kept as historical release notesBreaking change
SummaryWriter(comet_config=...)now raisesTypeError(consistent with the visdom/TorchVis removals). Related open issues #723 and #639 can be closed as obsolete once this merges.Verification
ruff check tensorboardX: cleanmypy tensorboardX: no issues in 13 source files🤖 Generated with Claude Code