Prompt template submit - #2860
Conversation
…, add README.zh_Hans.md
…, add README.zh_Hans.md
Hi @crazywoola — thanks for the review. I've fixed it: the PR now only changes one .difypkg file (tanzhangjia/prompt-template/prompt-template-0.1.0.difypkg); the extra source files have been removed from the branch. I also updated the package manifest (added repo/contact) and made the README English-primary. Could you please re-trigger/approve CI on the latest commit? Thanks! |
crazywoola
left a comment
There was a problem hiding this comment.
❌ Request Changes
Decision: Request changes
Failed Checks
| Check | Status | Detail | Required action |
|---|---|---|---|
Icon validation |
❌ Fail | icon file not found: _assets/icon.svg | Provide a real custom icon file under _assets/ and reference it from manifest.yaml. |
Install test |
❌ Fail | Command failed (1): /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/.venv/bin/python /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/toolkit/validator/test-plugin-install.py -d /var/folders/vc/vfsgl8611qn5… | Fix the plugin so test-plugin-install.py passes. |
Packaging test |
❌ Fail | Command failed (1): /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/.venv/bin/python /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/toolkit/uploader/upload-package.py -d /var/folders/vc/vfsgl8611qn508whms… | Fix the plugin so upload-package.py --test passes. |
Full Check Results
| Check | Status | Detail | Required action |
|---|---|---|---|
PR content language |
✅ Pass | PR title/body CJK ratio=0.0% (zh=0, en=1574, ignored_zh=0, allowed_zh<=0) | None. |
Project structure |
✅ Pass | All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: no. | None. |
Manifest author |
✅ Pass | author is valid. | None. |
Icon validation |
❌ Fail | icon file not found: _assets/icon.svg | Provide a real custom icon file under _assets/ and reference it from manifest.yaml. |
Version check |
✅ Pass | version 0.1.0 is available. | None. |
README language |
✅ Pass | README.md CJK ratio=0.0% (zh=0, en=2409, allowed_zh<=0) | None. |
PRIVACY.md |
✅ Pass | PRIVACY.md exists and is non-empty. | None. |
Dependency install |
✅ Pass | requirements installed successfully. | None. |
dify_plugin version |
✅ Pass | dify_plugin version 0.10.2 satisfies >= 0.9.0. | None. |
Install test |
❌ Fail | Command failed (1): /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/.venv/bin/python /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/toolkit/validator/test-plugin-install.py -d /var/folders/vc/vfsgl8611qn5… | Fix the plugin so test-plugin-install.py passes. |
Packaging test |
❌ Fail | Command failed (1): /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/.venv/bin/python /var/folders/vc/vfsgl8611qn508whmstl644w0000gn/T/pr-review-helper-9xgrtphg/toolkit/uploader/upload-package.py -d /var/folders/vc/vfsgl8611qn508whms… | Fix the plugin so upload-package.py --test passes. |
Next steps
- Icon validation: Provide a real custom icon file under _assets/ and reference it from manifest.yaml.
- Install test: Fix the plugin so test-plugin-install.py passes.
- Packaging test: Fix the plugin so upload-package.py --test passes.
Please address these issues and push an update.
dify_plugin 0.10.2 requires the _assets directory to exist
(PluginRegistration._load_plugin_assets does os.scandir('_assets')),
and the manifest icon must reference _assets/icon.svg per marketplace spec.
|
@crazywoola please see the errors in the CI checks above. |
Restore the complete plugin source (manifest.yaml, _assets/icon.svg, README, PRIVACY, main.py, provider/, tools/, requirements) alongside the packaged .difypkg so the marketplace icon/install/packaging checks can find _assets/icon.svg referenced by manifest.yaml.
…source files) Marketplace plugin submissions ship a single .difypkg. The package already contains the full source tree (manifest, README, PRIVACY, main.py, provider/, tools/, _assets/icon.svg).
|
Hi @crazywoola — thanks for the review. I've fixed all the blocking checks. The submission is now a single packaged .difypkg (no loose source files), and I validated the package locally with the marketplace toolkit (0 blocking failures). Checklist: Icon validation ✅ Latest commit: f7b7f6c. Could you please re-run CI / approve? Thanks! |
🤖 CI Summary
What's wrongThree blocking errors:
How to fix
Then push a new commit to re-trigger CI. Thank you! 🙏 |
Plugin Submission
Plugin information
Submission type
What changed
Risk level
Required checks
.envfiles,.gitdirectories, virtual environments, caches, logs, or IDE files.PRIVACY.mdor a hosted privacy policy, andmanifest.yamlreferences it.Security and privacy notes
Local validation
Reviewer notes