Skip to content

rm variable name of variable api - #595

Merged
RiskeyL merged 2 commits into
langgenius:mainfrom
hjlarry:p4
Dec 12, 2025
Merged

rm variable name of variable api#595
RiskeyL merged 2 commits into
langgenius:mainfrom
hjlarry:p4

Conversation

@hjlarry

@hjlarry hjlarry commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

fix langgenius/dify#29239

as the DosuBot said, there is no variable name in this API

Copilot AI review requested due to automatic review settings December 7, 2025 11:35
@hjlarry
hjlarry requested a review from RiskeyL as a code owner December 7, 2025 11:35
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 7, 2025
@github-actions

github-actions Bot commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

⏸️ Documentation sync is pending approval

This PR requires approval from a maintainer before automatic synchronization can proceed.

Once approved, the documentation will be automatically translated and synchronized.

@dosubot dosubot Bot added the bug Something isn't working label Dec 7, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the variable_name query parameter from the chatflow API's "Get Conversation Variables" endpoint in the English OpenAPI specification, addressing issue #29239 where this parameter was incorrectly documented as part of the API.

Key Changes

  • Removed VariableNameQueryParam reference from the /conversations/{conversation_id}/variables GET endpoint parameters
  • Removed the VariableNameQueryParam component definition from the parameters section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hjlarry
hjlarry marked this pull request as draft December 8, 2025 01:24
@hjlarry
hjlarry marked this pull request as ready for review December 12, 2025 06:28
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 12, 2025
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@RiskeyL
RiskeyL merged commit 57e04ab into langgenius:main Dec 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] variable_name filter not working in GET /conversations/{conversation_id}/variables

3 participants