-
Notifications
You must be signed in to change notification settings - Fork 766
feat(index): add FTS document granularity #7788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xuanwo
wants to merge
11
commits into
main
Choose a base branch
from
xuanwo/fts-element-document-phase1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
02490a4
feat(index): support element-document FTS targets
Xuanwo 4dbbd83
fix(index): preserve FTS coordinates in MAXSCORE
Xuanwo 93bb231
feat(index): add FTS document granularity
Xuanwo aea530b
fix(index): complete FTS document granularity support
Xuanwo 738dabb
Merge branch 'main' into xuanwo/fts-element-document-phase1
Xuanwo 3bca849
fix(index): initialize bulk FTS document coordinates
Xuanwo b25d7d5
Merge remote-tracking branch 'origin/main' into xuanwo/fts-element-do…
Xuanwo a4618da
test(index): assert schema-derived FTS type error
Xuanwo 9bcd750
fix(index): infer FTS query granularity
Xuanwo 6bb44dd
Merge origin/main into xuanwo/fts-element-document-phase1
Xuanwo 402db95
test(index): disambiguate row BM25 query
Xuanwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.lance; | ||
|
|
||
| /** The unit treated as one full-text-search document. */ | ||
| public enum DocumentGranularity { | ||
| /** All text selected from one dataset row belongs to one document. */ | ||
| ROW("row"), | ||
|
|
||
| /** Each element of the deepest list on the field path is one document. */ | ||
| LIST_ELEMENT("list_element"); | ||
|
|
||
| private final String rustString; | ||
|
|
||
| DocumentGranularity(String rustString) { | ||
| this.rustString = rustString; | ||
| } | ||
|
|
||
| /** Return the stable value understood by the Rust API and serialized index parameters. */ | ||
| public String toRustString() { | ||
| return rustString; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.