feat(namespace-dir): implement alter_transaction for DirectoryNamespace by XuQianJin-Stars · Pull Request #6974 · lance-format/lance

XuQianJin-Stars · 2026-05-28T02:27:43Z

Implement the alter_transaction method for DirectoryNamespace, which
allows altering a transaction's status and properties. This completes one
of the remaining unimplemented methods in the LanceNamespace trait.

Supported actions

SetStatusAction: change transaction status (Queued / Running / Succeeded / Failed / Canceled)
SetPropertyAction: set transaction properties with Overwrite / Fail / Skip modes
UnsetPropertyAction: remove transaction properties with Skip / Fail modes

All actions in a request are applied atomically — either all succeed, or
the operation fails with an appropriate error.

Persistence via sidecar

Since Lance embeds the Transaction into the manifest and treats it as
immutable, we cannot rewrite the transaction file in place. Previously,
alter_transaction only mutated properties in memory and returned them,
so subsequent describe_transaction / alter_transaction calls could
not observe the modifications.

To fix this, alterations are now persisted in a namespace-owned sidecar
file at:

{table}/_alter_transactions/{uuid}.json

This sidecar records the accumulated alterations (status, added /
overwritten properties, tombstoned properties). describe_transaction
and follow-up alter_transaction calls merge the sidecar on top of the
immutable transaction, so the altered state survives across calls.

Reserved keys

uuid, version, read_version, operation, and tag are treated as
reserved keys that cannot be modified via alter_transaction, since they
are derived from the immutable Transaction metadata. They are still
surfaced in the response for the caller's convenience.

Tests added

test_alter_transaction_set_status
test_alter_transaction_set_property
test_alter_transaction_set_property_fail_mode
test_alter_transaction_unset_property
test_alter_transaction_invalid_status
test_alter_transaction_not_found
test_alter_transaction_missing_id

claude

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

github-actions · 2026-05-28T02:28:04Z

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

codecov · 2026-05-28T03:05:05Z

Codecov Report

❌ Patch coverage is 86.89840% with 49 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
rust/lance-namespace-impls/src/dir.rs	86.89%	40 Missing and 9 partials ⚠️

📢 Thoughts on this report? Let us know!

Implement the alter_transaction method for DirectoryNamespace, which allows altering a transaction's status and properties. This completes one of the remaining unimplemented methods in the LanceNamespace trait. The implementation supports: - SetStatusAction: change transaction status (Queued/Running/Succeeded/Failed/Canceled) - SetPropertyAction: set transaction properties with Overwrite/Fail/Skip modes - UnsetPropertyAction: remove transaction properties with Skip/Fail modes All actions in a request are applied atomically - either all succeed or the operation fails with an appropriate error. Tests added: - test_alter_transaction_set_status - test_alter_transaction_set_property - test_alter_transaction_set_property_fail_mode - test_alter_transaction_unset_property - test_alter_transaction_invalid_status - test_alter_transaction_not_found - test_alter_transaction_missing_id

yanghua · 2026-06-30T12:45:45Z

        Ok(Self::transaction_response(version, &transaction))
    }

+    async fn alter_transaction(


Did you persist or save the changes?

Did you persist or save the changes?

I updated it.

Previously, alter_transaction only mutated properties in memory and returned them, so subsequent describe_transaction / alter_transaction calls could not observe the modifications. Since Lance embeds the Transaction into the manifest and treats it as immutable, we cannot rewrite the transaction file in place. Introduce a namespace-owned sidecar file at {table}/_alter_transactions/{uuid}.json that records the accumulated alterations (status, added/overwritten properties, tombstoned properties). describe_transaction and follow-up alter_transaction calls now merge the sidecar on top of the immutable transaction so the altered state survives across calls. Also treat uuid/version/read_version/operation/tag as reserved keys that cannot be modified, since they are derived from the immutable Transaction metadata.

…ved key checks

- Remove useless conversion .into() on lance_core::Error - Use RESERVED_KEYS.contains(&key) instead of iter().any()

yanghua

Left some comments.

yanghua · 2026-07-01T04:02:41Z


 [features]
 default = ["dir-aws", "dir-azure", "dir-gcp", "dir-oss", "dir-huggingface"]
-rest = ["dep:reqwest", "dep:serde"]


Do we need to change this file?

yanghua · 2026-07-01T04:12:40Z

+        create_scalar_table(&namespace, "users").await;
+        let transaction_id = create_scalar_index(&namespace, "users", "users_id_idx").await;
+
+        if let Some(txn_id) = transaction_id {


This style may cause false positives if it is None. It would be better to use expect(...) or assert!(transaction_id.is_some())

yanghua · 2026-07-01T04:14:59Z

+    }
+
+    #[tokio::test]
+    async fn test_alter_transaction_set_property_fail_mode() {


Using the reserved field uuid as the key results in zero coverage of the mode='Fail' branch.

- Cargo.toml: revert to original by dropping serde derive; sidecar now serializes/deserializes via serde_json::Value manually, so no changes to Cargo.toml are needed. - Replace 'if let Some(txn_id) = transaction_id' with expect(...) in five alter_transaction tests to avoid silent false-positive passes. - test_alter_transaction_set_property_fail_mode: use a non-reserved 'custom_key' (set once, then set again with mode='Fail') so the test actually exercises the mode='Fail' branch instead of tripping the reserved-key guard first.

Adopt the same pattern used in dir/manifest.rs, which relies on the built-in Serialize/Deserialize impls for Option<String>, HashMap<String, String> and HashSet<String> transitively provided by serde_json. - Replace hand-rolled serde_json::Value match with a single serde_json::from_slice::<Map<String, Value>> plus per-field from_value calls. - Fold the two-step to_json + serde_json::to_vec into a single to_json_bytes helper. - No Cargo.toml changes; still compiles under --no-default-features --features dir-aws where serde is optional. Net effect: -81 lines in dir.rs, all 8 alter_transaction tests still pass, cargo fmt/clippy clean.

yanghua

+1

claude Bot reviewed May 28, 2026

View reviewed changes

XuQianJin-Stars changed the title ~~feat(namespace-dir): implement alter_transaction for DirectoryNamespace~~ feat(namespace-dir): implement alter_transaction for DirectoryNamespace May 28, 2026

github-actions Bot added the enhancement New feature or request label May 28, 2026

XuQianJin-Stars force-pushed the feature/implement-alter-transaction branch from 6a68586 to c70209c Compare May 29, 2026 07:25

XuQianJin-Stars force-pushed the feature/implement-alter-transaction branch from c70209c to 8ffc563 Compare June 15, 2026 03:27

github-actions Bot added the A-namespace Namespace impls label Jun 15, 2026

XuQianJin-Stars force-pushed the feature/implement-alter-transaction branch 2 times, most recently from 96425c7 to 949f86a Compare June 24, 2026 02:02

XuQianJin-Stars force-pushed the feature/implement-alter-transaction branch from 949f86a to 363dc69 Compare June 30, 2026 09:28

yanghua reviewed Jun 30, 2026

View reviewed changes

XuQianJin-Stars added 3 commits July 1, 2026 09:59

style(namespace-impls): fix rustfmt issues in alter_transaction reser…

240d472

…ved key checks

fix: address clippy warnings in dir.rs

f140451

- Remove useless conversion .into() on lance_core::Error - Use RESERVED_KEYS.contains(&key) instead of iter().any()

yanghua reviewed Jul 1, 2026

View reviewed changes

XuQianJin-Stars added 2 commits July 1, 2026 13:04

yanghua approved these changes Jul 1, 2026

View reviewed changes

yanghua merged commit 784a876 into lance-format:main Jul 1, 2026
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(namespace-dir): implement alter_transaction for DirectoryNamespace#6974

feat(namespace-dir): implement alter_transaction for DirectoryNamespace#6974
yanghua merged 6 commits into
lance-format:mainfrom
XuQianJin-Stars:feature/implement-alter-transaction

XuQianJin-Stars commented May 28, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

codecov Bot commented May 28, 2026 •

edited

Loading

Uh oh!

yanghua Jun 30, 2026

Uh oh!

XuQianJin-Stars Jul 1, 2026

Uh oh!

yanghua left a comment

Uh oh!

yanghua Jul 1, 2026

Uh oh!

yanghua Jul 1, 2026

Uh oh!

yanghua Jul 1, 2026

Uh oh!

yanghua left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

XuQianJin-Stars commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Supported actions

Persistence via sidecar

Reserved keys

Tests added

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

codecov Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yanghua Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

XuQianJin-Stars Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

yanghua left a comment

Choose a reason for hiding this comment

Uh oh!

yanghua Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

yanghua Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

yanghua Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

yanghua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

XuQianJin-Stars commented May 28, 2026 •

edited

Loading

codecov Bot commented May 28, 2026 •

edited

Loading