fix(index): clean up IVF shuffler temp dir after index build#6957
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
@Xuanwo, @wjones127, hi! |
wjones127
approved these changes
May 27, 2026
wjones127
left a comment
wjones127
left a comment
Contributor
There was a problem hiding this comment.
Nice work. I appreciate the test. I made an optional suggestion to improve readability. Otherwise, I'm happy to merge this once CI is green.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Thanks! I applied the on_drop suggestion. CI run is green. |
Co-authored-by: Will Jones <[email protected]>
geserdugarov
force-pushed
the
fix-clean-tmp
branch
from
May 28, 2026 02:33
1efd512 to
055890b
Compare
Xuanwo
pushed a commit
that referenced
this pull request
Jul 13, 2026
…6980) # Summary Fixes an HNSW-IVF index build bug analogous to #6957, but in the legacy HNSW partition writer path. # Changes - Keeps the `TempStdDir` guard alive for the full `write_hnsw_quantization_index_partitions` function. - Prevents scratch `hnsw_part_*` files from disappearing before they are read back into the final index files. - No new test added: existing `index::vector::ivf::tests::test_create_index_nulls` already covers `IVF_HNSW_PQ` and `IVF_HNSW_SQ` with `IndexFileVersion::Legacy`. # Testing - `cargo test -p lance test_create_index_nulls -- --nocapture` - Result: 10 passed, including the legacy `IVF_HNSW_PQ` and `IVF_HNSW_SQ` cases. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved reliability when building IVF_HNSW indexes with concurrent per-partition jobs. * Ensured temporary scratch directories and intermediate files persist correctly during in-flight work, and are cleaned up consistently after errors. * Improved error propagation so index build failures stop background work promptly and report late task issues accurately. * **Tests** * Added Tokio-based coverage for scratch-directory lifetime, failure draining/abort behavior, and cleanup under isolated temporary directories. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a temporary directory leak in IVF index shuffling by ensuring auto-created shuffle directories are
cleaned up after index build work is complete.
Changes
TempDirguard instead of leaking thepath.
IvfShufflerwhen no caller-provided output directory is used.reading them.
responsibility.
streams are dropped.
Testing
cargo test -p lance-index vector::ivf::shuffler::test::test_shuffler_cleans_up_auto_temp_dir