feat(tally): seal canary readback runtime#55
Merged
Conversation
lamemustafa
marked this pull request as ready for review
July 22, 2026 19:36
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adds a crate-internal, read-only canary-ledger readback seam that accepts only the requested company GUID, identity-query commitment, and zero or one exact canary ledger. Raw response XML is redacted and never reaches commands, UI, or persistence. Test: cargo fmt --all --check; cargo test --locked -p bridge --lib tally::connection::tests::canary_readback_requires_exact_company_commitment_and_ledger_name; cargo clippy --locked -p bridge --all-targets -- -D warnings; compatibility gate; matrix markdown check; live-read boundary guard. Migration: none; no schema or sync behavior changes. Security: no Tally write path, raw Tally data, credentials, or broad export path added; changed Tally call uses the serial queue and single attempt. Rollback: revert this isolated commit; it has no command/UI/persistence consumer. Review checklist: serial queue requirement completed.