Skip to content

feat(tally): add sealed ledger canary readback profile#54

Merged
lamemustafa merged 1 commit into
masterfrom
tapish-codex/feat-tally-ledger-canary-readback
Jul 22, 2026
Merged

feat(tally): add sealed ledger canary readback profile#54
lamemustafa merged 1 commit into
masterfrom
tapish-codex/feat-tally-ledger-canary-readback

Conversation

@lamemustafa

Copy link
Copy Markdown
Owner

Closes #53

Functional summary

Adds ledger_canary_readback_v1: a sealed, read-only TDL export profile for verifying one separately approved, Bridge-generated synthetic ledger write canary. The profile:

  • validates the synthetic ledger name against a narrow literal-safe character set;
  • validates and redacts the fixed 64-hex query-identity digest;
  • applies an exact ledger-name filter and binds that digest to the returned company context;
  • remains an EXPORT request with no general ledger query or write dispatch path.

Validation

  • cargo fmt --all --check
  • cargo test -p bridge-tally-protocol
  • cargo clippy -p bridge-tally-protocol --all-targets -- -D warnings
  • cargo check --workspace
  • git diff --check

Migration and rollback

No data migration, persisted-state change, endpoint change, or command routing change. Roll back by reverting this single commit; it is not reachable from the runtime yet.

Security and Tally impact

This is intentionally a closed read-only profile. Dynamic values are syntactically constrained before XML rendering; the tests assert exported requests only and pin the template digest. No real Tally/company/ledger/credential data is included. Education-mode compatibility is unobserved and remains explicitly unknown pending the disposable-company canary flow.

Review checklist

  • Errors are actionable without exposing sensitive values.
  • New or changed commands validate inputs and surface user-safe errors.
  • AXAL protocol changes include a contract-level regression command or test.
  • No secrets, credentials, certificate data, personal data, customer data, local usernames, or absolute machine paths appear in source, fixtures, logs, screenshots, documentation, or Git metadata intended for publication.
  • Endpoints and command handlers enforce explicit input validation.
  • DSC, Tally, credential, endpoint, and document changes include explicit security impact notes.
  • Shared build and check commands pass without shell-specific syntax.
  • Platform-specific behavior is not changed; this portable protocol-only change has no missing platform evidence.
  • Existing workflow changes include rollback and migration compatibility.

@lamemustafa
lamemustafa force-pushed the tapish-codex/feat-tally-ledger-canary-readback branch from 296f38c to f68377a Compare July 22, 2026 18:44
@lamemustafa
lamemustafa marked this pull request as ready for review July 22, 2026 18:44

Copy link
Copy Markdown
Owner Author

CI rectify update: regenerated the compatibility surface and its matrix binding for the new sealed read profile. Local verification now passes the exact compatibility gate, matrix drift check, no-write live-read boundary check, protocol tests, formatting, and clippy. @codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f68377a2a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-protocol/src/xml_read_profiles.rs Outdated
Comment thread src-tauri/crates/bridge-tally-protocol/src/xml_read_profiles.rs
@lamemustafa
lamemustafa force-pushed the tapish-codex/feat-tally-ledger-canary-readback branch from f68377a to 452baa0 Compare July 22, 2026 18:54

Copy link
Copy Markdown
Owner Author

Both Codex findings were fixed in 452baa0, with targeted regression coverage and regenerated compatibility bindings. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 452baa08a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lamemustafa
lamemustafa merged commit 9600013 into master Jul 22, 2026
9 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/feat-tally-ledger-canary-readback branch July 22, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a sealed, filtered ledger readback for synthetic write-canary verification

1 participant