Skip to content

fix(tally): require parent for ledger creates#52

Merged
lamemustafa merged 1 commit into
masterfrom
tapish-codex/rectify-tally-ledger-parent
Jul 22, 2026
Merged

fix(tally): require parent for ledger creates#52
lamemustafa merged 1 commit into
masterfrom
tapish-codex/rectify-tally-ledger-parent

Conversation

@lamemustafa

@lamemustafa lamemustafa commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes #51: reject a controlled ledger create without an explicit parent before it can be previewed or authorized. This keeps the existing alter-state model intact and extends the synthetic XML-escaping test to cover the required parent.

Validation

  • cargo fmt --all --check
  • cargo test -p bridge-tally-write
  • cargo clippy -p bridge-tally-write --all-targets -- -D warnings
  • cargo check --workspace
  • git diff --check

Migration and rollback

No database migration or sync-behavior migration. No live Tally request or write was made. Roll back with git revert 0a671d2.

Security impact

Tally write-qualification change: it narrows the accepted payload set and adds no endpoint, credential, raw-data, or logging path.

Review checklist

@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 0a671d27a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lamemustafa
lamemustafa merged commit 415cda1 into master Jul 22, 2026
9 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/rectify-tally-ledger-parent branch July 22, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tally ledger create preview permits a missing required parent

1 participant