Skip to content

fix(tally): align guarded ledger import XML#50

Merged
lamemustafa merged 2 commits into
masterfrom
tapish-codex/rectify-ledger-import-wire
Jul 22, 2026
Merged

fix(tally): align guarded ledger import XML#50
lamemustafa merged 2 commits into
masterfrom
tapish-codex/rectify-ledger-import-wire

Conversation

@lamemustafa

@lamemustafa lamemustafa commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Functional summary

Aligns the network-free ledger import renderer with documented Tally master XML:

  • creates include the documented LEDGER/@NAME selector and child <NAME>;
  • rename alters select the existing name in the NAME attribute and emit the replacement child <NAME>;
  • optional-field Some → None alters fail closed until explicit Tally clear semantics are qualified.

Source issue

Part of #46.

Testing

Migration and rollback

  • Migration/sync impact: none; the crate remains network-free and cannot dispatch HTTP.
  • Destructive migration: none.
  • Rollback: revert d81c4bb then 85c1bc5.

Security and Tally impact

  • No endpoint, credential, storage, or live Tally write behavior changes.
  • The change narrows unsafe alters and corrects deterministic preview bytes only.
  • Live canary dispatch, vouchers, deletes, and generic writes remain out of scope.

@lamemustafa
lamemustafa marked this pull request as ready for review July 22, 2026 17:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85c1bc54a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/crates/bridge-tally-write/src/lib.rs Outdated
@lamemustafa
lamemustafa merged commit 0fed433 into master Jul 22, 2026
9 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/rectify-ledger-import-wire branch July 22, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant