Fix crash with unknown tooltip components (Meteor Compat)#297
Open
0xTas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash with unknown tooltip components (Meteor Compat)
Fixes the crash reported in this thread in the Lambda support Discord.
When Lambda encounters an unknown instance of TooltipData it mimics the vanilla logic of throwing an IllegalArgumentException. This is unnecessary and causes crashes when paired with mods like Meteor that create their own classes which implement the TooltipData interface.
This PR fixes that by ignoring unknown implementers instead of throwing on them, allowing the other mods' mixins to handle their implementers properly and avoiding crashes altogether.
Issue Link
https://discord.com/channels/834570721070022687/1508546671624065164/1508547813511004371