Skip to content

Slack Integration - #36

Open
timatron wants to merge 54 commits into
l3rady:masterfrom
alleyinteractive:feature/TOOL-494/slack
Open

Slack Integration#36
timatron wants to merge 54 commits into
l3rady:masterfrom
alleyinteractive:feature/TOOL-494/slack

Conversation

@timatron

@timatron timatron commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

This PR should be merged after #35

  • Added slack notifications and testing button
  • Separated notifications so they can be email, slack, or both
  • Reorganized settings page
  • Changed validation to not turn on notifications for email or slack unless required fields are valid
  • Test email or slack message are now triggered with a temporary transient
  • Removed javascript functions
  • Added descriptions to all functions

timatron and others added 30 commits December 27, 2019 19:28
…xternal-cron

Feature/tool 494/remove external cron
…xternal-cron

Feature/tool 494/remove external cron
Co-Authored-By: jomurgel <[email protected]>
Co-Authored-By: jomurgel <[email protected]>
@l3rady

l3rady commented Jan 6, 2020

Copy link
Copy Markdown
Owner

Some merge conflicts here. Can we clean up please? Cheers

@timatron

timatron commented Jan 6, 2020

Copy link
Copy Markdown
Contributor Author

@l3rady should be good to go now

@timatron

timatron commented Jan 6, 2020

Copy link
Copy Markdown
Contributor Author

i definitely plan on bulking out the filters and allowing overrides to the notification methods

@timatron

Copy link
Copy Markdown
Contributor Author

@l3rady filters in for you with comments

l3rady
l3rady previously approved these changes Feb 27, 2020
@timatron

Copy link
Copy Markdown
Contributor Author

hey @l3rady this is ready to roll, sorry for some of the unsigned commits, can we turn that off for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants