Skip to content

[build]: pin accelerate-kt torch 2.9.1 dependency #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimmyPeilinLi merged 1 commit into from
Apr 29, 2026
Merged

[build]: pin accelerate-kt torch 2.9.1 dependency #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"packaging>=20.0",
"psutil",
"pyyaml",
"torch>=2.10,<2.12",
"torch==2.9.1",

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning a dependency to an exact version (==2.9.1) in setup.py is generally discouraged for libraries as it can lead to version conflicts for downstream users. If the intent is to avoid versions 2.10 and 2.11 while ensuring compatibility with the 2.9.x series, consider using a version range like torch>=2.9.1,<2.10.0. This provides more flexibility for patch updates and environment resolution while still achieving the goal of excluding the problematic versions.

Suggested change
"torch==2.9.1",
"torch>=2.9.1,<2.10.0",

"huggingface_hub>=0.21.0",
"safetensors>=0.4.3",
],
Expand Down
Loading