fix(codex): preserve thread lock fallback - #1230
Open
Pepen0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Codex API/Desktop-hosted Firstmate sessions becoming read-only when process ancestry inspection is unavailable.
This preserves process-backed harness PID ownership, including the current Claude outermost-ancestry behavior, and adds a
CODEX_THREAD_IDfallback for Codex sessions wherepscannot expose a localcodexparent process.Validation
FM_HOME=/private/tmp/fm-codex-thread-test-home CODEX_THREAD_ID=fm-test-thread-1 bin/fm-session-start.shlock acquired: codex thread fm-test-thread-1primary harness: codextests/fm-grok-harness.test.shKnown unrelated local issue
tests/fm-turnend-guard.test.shfails locally on Pi TypeScript extension import with Node v20:TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts"main.