Skip to content

Create k8s-metrics-reviewer.md for SIG-Instrumentation#9035

Open
CatherineF-dev wants to merge 3 commits into
kubernetes:mainfrom
CatherineF-dev:master
Open

Create k8s-metrics-reviewer.md for SIG-Instrumentation#9035
CatherineF-dev wants to merge 3 commits into
kubernetes:mainfrom
CatherineF-dev:master

Conversation

@CatherineF-dev

@CatherineF-dev CatherineF-dev commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Add SIG-Instrumentation Metrics Review guidelines for reviewing Kubernetes metrics changes, including stability framework and naming conventions.

Which issue(s) this PR fixes:

Fixes #9036

@k8s-ci-robot k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jun 19, 2026
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@CatherineF-dev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-verify ebc12b7 link true /test pull-community-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@CatherineF-dev

Copy link
Copy Markdown
Contributor Author

@dgrisonnet

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread contributors/devel/sig-instrumentation/k8s-metrics-reviewer/SKILL.md Outdated
Comment thread contributors/devel/sig-instrumentation/k8s-metrics-reviewer/SKILL.md Outdated
Comment thread contributors/devel/sig-instrumentation/k8s-metrics-reviewer/SKILL.md Outdated
Comment thread contributors/devel/sig-instrumentation/k8s-metrics-reviewer/SKILL.md Outdated
@@ -0,0 +1,34 @@
# SIG-Instrumentation Agent Skills

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README seems specific to only metrics but contributors/devel/sig-instrumentation contains logging, events and traces style guides too

@richabanker

Copy link
Copy Markdown
Contributor

/lgtm
Consider creating separate dirs for each pillar (metrics / traces / logs / events) and have separate READMEs for each.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sig-instrumentation]: standardize telemetry reviews

4 participants